-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spec for ProgrammaticSaveAs.md #3777
Open
Master-Ukulele
wants to merge
13
commits into
main
Choose a base branch
from
api-programmaticsaveas
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+396
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-risney
requested changes
Sep 15, 2023
Add explanations, examples. Add property 'Cancel', 'SuppressDefaultDialog'
vickiez
reviewed
Oct 2, 2023
david-risney
reviewed
Oct 2, 2023
david-risney
requested changes
Oct 2, 2023
Master-Ukulele
commented
Oct 4, 2023
oldnewthing
reviewed
Oct 4, 2023
MikeHillberg
reviewed
Oct 5, 2023
MikeHillberg
reviewed
Oct 5, 2023
FrankC-msft
reviewed
Oct 5, 2023
david-risney
reviewed
Oct 5, 2023
david-risney
approved these changes
Oct 5, 2023
Master-Ukulele
commented
Oct 6, 2023
- More accurate the description for different Kind, including top-level document, subresources, wiki link. - Rewrite the sample code. The methods of add event handler were removed. In new sample code, one method will both register handler and call save as. - Add comment to address get_ContentMimeType can help the Kind selection. - Add comment to address the CoreWebView2SaveAsUIResults will help end developer know the error if API call failed.
Master-Ukulele
added
the
review completed
WebView2 API Proposal that's been reviewed and now needs final update and push
label
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
API Proposal Review
WebView2 API Proposal for review.
review completed
WebView2 API Proposal that's been reviewed and now needs final update and push
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a review for the new Programmatic Save As API